Refactor Hostname validator
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Jul 3, 2024
| @@ -63,7 +62,7 @@ To check for IP addresses only, you can use the example below: | |||
| ```php | |||
| use Laminas\Validator\Hostname; | |||
|
|
|||
| $validator = new Hostname(Hostname::ALLOW_IP); | |||
| $validator = new Hostname(['allow' => Hostname::ALLOW_IP]); | |||
There was a problem hiding this comment.
Is the single parameter approach still working?
There was a problem hiding this comment.
Nope, only an options array is accepted
- Only allow a well known array shape as options for the constructor - Add types everywhere - Replace internal options array with RO props - Remove option setters and getters Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
v3/refactor-hostname
branch
from
63c2e2b
to
3bffa9d
Compare
gsteel
added a commit
to gsteel/laminas-validator
that referenced
this pull request
Jul 4, 2024
In laminas#298 the `$validTlds` property declaration was changed but the regex in the script was not. This patch also removes the check for `ext-intl` which is already available in CI, and instead outputs an error when not available. This has the side effect of 100% type coverage Signed-off-by: George Steel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description